Ensure config_flow abort reasons have translations
Proposed change
Ensure config_flow abort reasons have translations:
- Prevent new violations from being added
- Add a parametrize fixture around existing violations
This is a partial implementation of #127787, which focuses on config_flow abort reasons.
Follow-ups planned:
- [ ] Check
OptionsFlowManagerflow abort reasons - [ ] Check
errors(when flow result is FORM) - [ ] Check
title/description(when flow result is FORM) - [ ] Check
data_schema(when flow result is FORM) - [ ] Check
AbstractOAuth2FlowHandlerfor all expected reasons
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [x] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [x] I have followed the perfect PR recommendations
- [x] The code has been formatted using Ruff (
ruff format homeassistant tests) - [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [ ] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
To help with the load of incoming pull requests:
- [x] I have reviewed two other open pull requests in this repository.
Don't we risk "forgetting" and these won't be fixed (if it's not managed in a central place rather than a fixture in each component test)?
Don't we risk "forgetting" and these won't be fixed (if it's not managed in a central place rather than a fixture in each component test)?
They look tracked in #127811
Don't we risk "forgetting" and these won't be fixed (if it's not managed in a central place rather than a fixture in each component test)?
The tracking as an issue is rather hard to maintain. Without the fixture they will keep creeping in until all of them are fixed. After this us merged we can still make runs disabling the fixture temporarily to update the issue.