core icon indicating copy to clipboard operation
core copied to clipboard

Two missing strings for translating Mold indicator name in Lokalise

Open NoRi2909 opened this issue 1 year ago • 3 comments

The problem

The Mold indicator helper name cannot be translated in the Create Helper dialog and the title of the following setup dialog because two strings are not available in Lokalise.

Here two screenshots running the German UI:

Screenshot 2024-10-10 22 42 28

Screenshot 2024-10-10 22 49 06

Guessing from comparing to other Helpers the following two strings are missing in Lokalise:

  component::mold_indicator::title
  component::mold_indicator::config::step::user::title

Those should contain

  Mold Indicator
  Create Mold Indicator

Currently they cannot be found in Lokalise.

Edit: Just nocticed that we have the same bug with History Stats and Random:

 component::history_stats::title
 component::history_stats::config::step::user::title
 component::random::title

Those should contain

 History Stats
 Create History Stats
 Random

But we still have

 component::random::config::step::user::title
 Random helper

which is probably outdated, as Random now forks into Randon binary sensor and Random sensor.

What version of Home Assistant Core has the issue?

core-2024.10.1

What was the last working version of Home Assistant Core?

n/a

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

NoRi2909 avatar Oct 10 '24 20:10 NoRi2909

Hi @NoRi2909 thanks for reporting this. Actually the title strings are missing in strings.json. If you want, feel free to add these missing strings. This would be a good first contribution. Further if you are comfortable with contributing this, please don't hesitate to go ahead with the missing strings for history_stats and random helpers - any contribution would be highly appreciated 🙂 regards, Michael

mib1185 avatar Oct 11 '24 10:10 mib1185

Could you please add a proper label to this pull request so that I can contribute to the issue?

rahulsamant37 avatar Oct 11 '24 21:10 rahulsamant37

@Shubham-Goswami06 Great, the string just landed in Lokalise and is already translated into German. 😃

If you like to go after a few more similar bugs, have a look at https://github.com/home-assistant/core/issues/128367 where we already got the OK to move ahead. And https://github.com/home-assistant/core/issues/128341 with a simple typo.

NoRi2909 avatar Oct 21 '24 20:10 NoRi2909