core icon indicating copy to clipboard operation
core copied to clipboard

Wrong use of "option" instead of "entity" for Humidifier

Open NoRi2909 opened this issue 1 year ago • 5 comments

The problem

In the string

 component::generic_hygrostat::config::step::user::data_description::min_cycle_duration

the word "option" should be replaced by "entity":

"Set a minimum amount of time that the switch specified in the humidifier option must be in its current state prior to being switched either off or on."

For consistency the corresponding description for a generic thermostat should also be reworded:

 component::generic_thermostat::config::step::user::data_description::min_cycle_duration

"Set a minimum amount of time that the switch specified must be in its current state prior to being switched either off or on. This option will be ignored if the keep alive option is set."

to

"Set a minimum amount of time that the switch specified in the climate entity must be in its current state prior to being switched either off or on."

Please verify if the second sentence after that one is still valid, I don't see that "Keep alive" option when creating a generic thermostat helper.

What version of Home Assistant Core has the issue?

core-2024.10.1

What was the last working version of Home Assistant Core?

n/a

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

NoRi2909 avatar Oct 10 '24 17:10 NoRi2909

Hey there @shulyaka, mind taking a look at this issue as it has been labeled with an integration (generic_hygrostat) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of generic_hygrostat can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign generic_hygrostat Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


generic_hygrostat documentation generic_hygrostat source (message by IssueLinks)

home-assistant[bot] avatar Oct 11 '24 10:10 home-assistant[bot]

@NoRi2909 I see that you have a few issues around translations. Is there a way I can help you set up a development environment and help you with creating your own PRs? This way you don't have to create issues but can just directly fix the problem, which goes a lot quicker :)

joostlek avatar Oct 11 '24 11:10 joostlek

@joostlek For the moment I'm just happy that I was able to dig through that endless pile of inconsistent and misleading German translations in Lokalise. ;)

I will take a break the next days as this was certainly over 1000 changes across Core, Frontend and mainly Android in one week. Now I'll wait for the next betas to see if I did brake or overlook something. It was just necessary to make everything as consistent as possible so we don't end up triggering rollbacks in some places.

I will definitely try to do my own PRs in the future to simplify the process for you guys and me, but for the next days learning to master Github would be too much for me.

So thank you very much for your kind offer to help me with that, I will come back to that in the next weeks, OK?

NoRi2909 avatar Oct 11 '24 11:10 NoRi2909

I mean, don't get me wrong, you're doing an awesome job. So once you're ready for it, feel free to hit me up on discord and I can see what we can do to help you :)

joostlek avatar Oct 11 '24 11:10 joostlek

Will create an independent PR that solves the issue in a slightly different way.

NoRi2909 avatar Nov 21 '24 15:11 NoRi2909