core icon indicating copy to clipboard operation
core copied to clipboard

PLural / Singular mismatch in two classes_not_matching::description strings

Open NoRi2909 opened this issue 1 year ago • 1 comments

The problem

There are two error messages for sensor groups:

 component::group::issues::state_classes_not_matching::description
 "State classes … on source entities … needs to be same for sensor group …"


 component::group::issues::device_classes_not_matching::description
 "Device classes … on source entities … needs to be same for sensor group …"

The grammar is broken with plural at the beginning and singular in "needs to be same"

Should be fixed by rewording as:

 "… classes … have to be identical …"

I see that fix already applied in the German translation so the English original no longer matches. :-)

What version of Home Assistant Core has the issue?

core-2024.10.1

What was the last working version of Home Assistant Core?

n/a

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

NoRi2909 avatar Oct 10 '24 13:10 NoRi2909

Hey there @home-assistant/core, mind taking a look at this issue as it has been labeled with an integration (group) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of group can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign group Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


group documentation group source (message by IssueLinks)

home-assistant[bot] avatar Oct 10 '24 16:10 home-assistant[bot]

This has been fixed in https://github.com/home-assistant/core/pull/131150

NoRi2909 avatar Nov 22 '24 07:11 NoRi2909