core icon indicating copy to clipboard operation
core copied to clipboard

Mark custom components that overwrite core

Open MindFreeze opened this issue 1 year ago • 1 comments

Proposed change

Sometimes users override a core integration, without them knowing they do. This often results in unexpected behavior.

While it is part of the design of core to allow for overriding core integration, we should make the user more aware they actually are override a core integration.

This can, for example, be listed in the integrations page and maybe we can consider adding a flag to the integration dashboard card as well? (like we do for custom or cloud).

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

MindFreeze avatar Oct 08 '24 13:10 MindFreeze

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Oct 09 '24 07:10 home-assistant[bot]

@frenck frontend has been finalized. Can you merge this pls?

MindFreeze avatar Oct 16 '24 06:10 MindFreeze

@frenck frontend has been finalized. Can you merge this pls?

The frontend PR hasn't been approved or merged. Additionally the frontend PR isn't linked up in the PR description.

As far as I can see, this PR cannot be merged yet.

../Frenck

frenck avatar Oct 16 '24 06:10 frenck

Thanks for linking up; frontend has been approved as well.

../Frenck

frenck avatar Oct 16 '24 07:10 frenck