core icon indicating copy to clipboard operation
core copied to clipboard

Add motion detected binary_sensor for tplink

Open rytilahti opened this issue 1 year ago • 7 comments

Proposed change

This PR adds a new motion_detected binary sensor for tplink, exposed by hub-connected Tapo T100 sensors. ~~This PR itself has not been tested against a real device as I have none, but the backend support has been reported to work and the change itself is straightforward.~~ Tested to work with a real device.

image

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #127167
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

rytilahti avatar Oct 07 '24 20:10 rytilahti

Hey there @bdraco, @sdb9696, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tplink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tplink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Oct 07 '24 20:10 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Oct 08 '24 12:10 home-assistant[bot]

Just a quick update, I got a test device and it's working as expected. Added a screenshot to the PR desc.

rytilahti avatar Oct 09 '24 10:10 rytilahti

https://github.com/home-assistant/core/pull/128022 should address the device class issue.

sdb9696 avatar Oct 09 '24 13:10 sdb9696

I removed the translation indirection in favor of using the device class defaults, #128022 needs to be merged first before this can proceed.

rytilahti avatar Oct 09 '24 15:10 rytilahti

Hello, Is it possible to know when / if this will land in the main docker image? I need to connect a tepo T100 motion detector to homeassistant, I would just like to know how long approximately I need to wait for it to be supported, and I'm not very accustomed to github. Of course, I would understand if there would be delay or long term impossibility, it's not a complain at all, but a plain question. Thanks you!

Froggy232 avatar Oct 12 '24 18:10 Froggy232

Hi @Froggy232! As this is a new feature, the earliest chance is for 2024.11 release coming up early next month. Given how simple this change is, and as the requested changes are related to our internal documentation, I'm rather confident this will make into that release .

rytilahti avatar Oct 12 '24 21:10 rytilahti