core icon indicating copy to clipboard operation
core copied to clipboard

Fix wrong DPTypes returned by Tuya's cloud

Open azerty9971 opened this issue 4 months ago • 3 comments

Breaking change

Proposed change

These changes add some more robustness to some incorrect data returned by the tuya cloud. I've contacted Tuya and they claim that these changes should be implemented at HA's side since the data is correct (just ill formatted according to us). I've made the changes so that they only trigger in those specific scenarios so that there is no/minimal performance impact.

Type of change

  • [ ] Dependency upgrade
  • [X] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [X] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: None (I've had the issue on my own installation and did not report it)
  • This PR is related to issue: None (same as above)
  • Link to documentation pull request:

Checklist

  • [X] The code change is tested and works locally.
  • [X] Local tests pass. Your PR cannot be merged unless tests pass
  • [X] There is no commented out code in this PR.
  • [X] I have followed the development checklist
  • [X] I have followed the perfect PR recommendations
  • [X] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

azerty9971 avatar Oct 07 '24 16:10 azerty9971