core icon indicating copy to clipboard operation
core copied to clipboard

Z-Wave JS: support non-dimmable color lights

Open AlCalzone opened this issue 1 year ago • 2 comments

Breaking change

Proposed change

This PR is another attempt at https://github.com/home-assistant/core/pull/122639, but this time it considers the case where all three switch-type CCs exist: Binary Switch, Multilevel Switch and Color Switch. When a combination of Multilevel Switch and Color Switch can be made, it is now preferred over the Binary Switch and Color Switch combination, resulting in a color light plus a switch in the above case.

To achieve this, I had to limit the search of required_value and absent_values to the same endpoint as the primary value. IMO the previous behavior was not correct, as endpoints have to be considered separate sub-devices. Mixing and matching values across endpoints into one entity is unsound.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

fixes: https://github.com/home-assistant/core/issues/120139 fixes: https://github.com/zwave-js/certification-backlog/issues/19

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

AlCalzone avatar Oct 07 '24 12:10 AlCalzone

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Oct 07 '24 12:10 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Oct 09 '24 13:10 home-assistant[bot]