core icon indicating copy to clipboard operation
core copied to clipboard

Add testing framework for LG ThinQ

Open joostlek opened this issue 1 year ago • 4 comments

Proposed change

This PR lays a foundation of a testframework, that can be used to see what devices create what entities. The snapshots can be updated with pytest ./tests/components/lg_thinq --snapshot-update

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [x] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

joostlek avatar Oct 01 '24 15:10 joostlek

Apparently it doesn't ping here, cc @LG-ThinQ-Integration

joostlek avatar Oct 01 '24 15:10 joostlek

@LG-ThinQ-Integration Can you look at this PR and let me know what you think? I think having a way to at least fixate entities is a nice way to make sure every device exposes the right stuff like expected

joostlek avatar Oct 04 '24 12:10 joostlek

Apparently it doesn't ping here, cc @LG-ThinQ-Integration

Do you mean you can't reach the ThinQ Cloud, even though you made the PAT with your account?

LG-ThinQ-Integration avatar Oct 07 '24 01:10 LG-ThinQ-Integration

@LG-ThinQ-Integration Can you look at this PR and let me know what you think? I think having a way to at least fixate entities is a nice way to make sure every device exposes the right stuff like expected

Oh, you made tests for us. I really appreciate it. I think it is great. We'd better add tests based on this commit.

LG-ThinQ-Integration avatar Oct 07 '24 01:10 LG-ThinQ-Integration

Do you mean you can't reach the ThinQ Cloud, even though you made the PAT with your account?

No no, I mean that when I made this PR you didn't get pinged

joostlek avatar Oct 07 '24 06:10 joostlek

Do you have any remarks or should we merge it?

joostlek avatar Oct 07 '24 06:10 joostlek

Do you have any remarks or should we merge it?

Currently we don't have any remarks. I think you should merge it. Thank you again :)

LG-ThinQ-Integration avatar Oct 07 '24 06:10 LG-ThinQ-Integration

Do you mean you can't reach the ThinQ Cloud, even though you made the PAT with your account?

No no, I mean that when I made this PR you didn't get pinged

Oh, I got it now. :)

LG-ThinQ-Integration avatar Oct 07 '24 07:10 LG-ThinQ-Integration