core icon indicating copy to clipboard operation
core copied to clipboard

Add Tesla Fleet grid status

Open JEMcats opened this issue 1 year ago • 7 comments

Proposed change

This pull request adds 2 changes:

  • Grid Connected / Disconnected Status ('Unknown'/'Connected'/'Disconnected'/'Disconnected intentionally' )
  • Storm Watch Active / Standby ('True'/'False')

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR is related to PR: #126003

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Updated Docs

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

JEMcats avatar Sep 22 '24 16:09 JEMcats

Hey there @bre77, mind taking a look at this pull request as it has been labeled with an integration (tesla_fleet) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tesla_fleet can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tesla_fleet Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Sep 22 '24 16:09 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Sep 24 '24 07:09 home-assistant[bot]

@JEMcats run pytest ./tests/components/tesla_fleet --snapshot-update in your dev environment to update the test snapshots and commit the binary_sensory.ambr file it will update.

Bre77 avatar Sep 24 '24 23:09 Bre77

You can use this as your documentation: https://github.com/home-assistant/home-assistant.io/pull/34911

Bre77 avatar Sep 25 '24 00:09 Bre77

@JEMcats sorry I made a bad assumption that your translations would be up to date. Delete the *.ambr files you generated, run script/setup then re-run the pytest command, this should generate some entries in sensors.ambr for the grid status entity only.

Bre77 avatar Sep 25 '24 01:09 Bre77

I completed those steps and there is nothing new to commit.

JEMcats avatar Sep 25 '24 19:09 JEMcats

I compiled the translations and updated the *.ambr files. d8f61c0

JEMcats avatar Sep 25 '24 20:09 JEMcats