core
core copied to clipboard
Bump aiovlc to 0.5.0
Proposed change
diff: https://github.com/MartinHjelmare/aiovlc/compare/v0.3.2...v0.5.0
Type of change
- [x] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [x] I have followed the perfect PR recommendations
- [x] The code has been formatted using Ruff (
ruff format homeassistant tests) - [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [ ] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Hey there @rodripf, @martinhjelmare, mind taking a look at this pull request as it has been labeled with an integration (vlc_telnet) you are listed as a code owner for? Thanks!
Code owner commands
Code owners of vlc_telnet can trigger bot actions by commenting:
@home-assistant closeCloses the pull request.@home-assistant rename Awesome new titleRenames the pull request.@home-assistant reopenReopen the pull request.@home-assistant unassign vlc_telnetRemoves the current integration label and assignees on the pull request, add the integration domain after the command.@home-assistant add-label needs-more-informationAdd a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.@home-assistant remove-label needs-more-informationRemove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
We could not detect an OSI-approved license for [email protected]: Other/Proprietary License
mhhh ... why :thinking:
$ pip show aiovlc
Name: aiovlc
Version: 0.5.0
Summary: Control VLC over telnet connection using asyncio
Home-page: https://github.com/MartinHjelmare/aiovlc
Author: Martin Hjelmare
Author-email: [email protected]
License: Apache Software License 2.0
Location: /home/vscode/.local/ha-venv/lib/python3.12/site-packages
Requires: rich, typer
Required-by:
pip-licenses -d -p aiovlc
Name Version License Description
aiovlc 0.5.0 Other/Proprietary License Control VLC over telnet connection using asyncio
The classifier was removed in the diff. Our license audit is too fragile to understand anything else.
Fix for the license classifier -> https://github.com/MartinHjelmare/aiovlc/pull/268
0.5.1 is released.
both test failures are not related
@MartinHjelmare should we additionally set the timeout while instantiating the vlc class in the vlc_telnet component, or is the default timeout of 10s sufficient? What do you think?
If we want to avoid the warning about slow update we could set the timeout to 9 seconds.