core icon indicating copy to clipboard operation
core copied to clipboard

Add text platform to LG ThinQ integration

Open LG-ThinQ-Integration opened this issue 1 year ago • 2 comments

Breaking change

Proposed change

Add text platform to LG ThinQ integration

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/34836

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

LG-ThinQ-Integration avatar Sep 19 '24 05:09 LG-ThinQ-Integration

Because mqtt is merged, I changed a little bit on coordinator access in runtime_data.

LG-ThinQ-Integration avatar Sep 23 '24 07:09 LG-ThinQ-Integration

Is there anything to talk about more in this PR? Please let me know.

LG-ThinQ-Integration avatar Oct 10 '24 06:10 LG-ThinQ-Integration

@joostlek Thank you for everything you've done. :) I am happy to say that this is the last platform. Ta-da~! After this PR, we will add some minor PRs to fix functional issues or add some entities, etc.

LG-ThinQ-Integration avatar Oct 17 '24 00:10 LG-ThinQ-Integration

Could you let us know the progress about this PR?

LG-ThinQ-Integration avatar Oct 21 '24 07:10 LG-ThinQ-Integration

Oh hi! 👋

We've discussed this PR at length and concluded that it isn't valid. We shouldn't be using a text platform to work around things like this.

In the end, the use of a time entity is a good route to go; however, we are not able to reset it to None (and thus disable the timer).

The conclusion right now is thus, that we don't have a good way to represent these control points in Home Assistant. We do think the use case for these specific entities is small, and therefore, we recommend not including these controls in Home Assistant at this point.

../Frenck

frenck avatar Oct 25 '24 23:10 frenck