Home connect number platform with temperature set points entities
Breaking change
Proposed change
Add number platform and include temperature setpoints.
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [X] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
EDIT: This platform fetches from the API the "step", maximum and minimum values at the entry setup, which might not be the best idea. It also fetches while updating the entity if at the entry setup wasn't able to obtaine the values, maybe this should be the only way to do it to avoid slow starts.
This PR will be keept in draft until #126143 gets merged, as some code can be refactored once merged, but it can be already reviewed as it will contain small changes.
Checklist
- [X] The code change is tested and works locally.
- [X] Local tests pass. Your PR cannot be merged unless tests pass
- [X] There is no commented out code in this PR.
- [X] I have followed the development checklist
- [X] I have followed the perfect PR recommendations
- [X] The code has been formatted using Ruff (
ruff format homeassistant tests) - [X] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [X] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [X] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [X] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Hey there @davidmstraub, mind taking a look at this pull request as it has been labeled with an integration (home_connect) you are listed as a code owner for? Thanks!
Code owner commands
Code owners of home_connect can trigger bot actions by commenting:
@home-assistant closeCloses the pull request.@home-assistant rename Awesome new titleRenames the pull request.@home-assistant reopenReopen the pull request.@home-assistant unassign home_connectRemoves the current integration label and assignees on the pull request, add the integration domain after the command.@home-assistant add-label needs-more-informationAdd a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.@home-assistant remove-label needs-more-informationRemove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
Only one platform per PR
I just deleted from the Number platform HomeConnectNumberEntityDescription because I thought that if no additional members were added, it wasn't needed. But I saw at other platforms from this integration that it contains entity descriptions without any additional members (for example, HomeConnectSwitchEntityDescription).
Should I keep HomeConnectNumberEntityDescription or should I delete it?
If there's no need to extend it, don't extend it :)
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
Docs are missing as well
Docs updated as well!
Merge conflict