core icon indicating copy to clipboard operation
core copied to clipboard

Add Squeezebox service update entities

Open pssc opened this issue 1 year ago • 3 comments

To add update entities for LMS server version and plugin updates.

This is in a series of PRs To follow:-

Adds the ability to clean up devices with no entities on reload. eg state players Improve reload Move LMS server/player discovery out of media player Add ssdp discovery to allow server discovery without a HW player being found Proactive player discovery in the config flow.

Completed:-

moving common elements to init and some code improvements #122396 Add Squeezebox server service binary sensors with coordinator #122473 Add server status sensors via coordinator #125349

Proposed change

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/34690

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

pssc avatar Sep 11 '24 16:09 pssc

Hey there @rajlaud, mind taking a look at this pull request as it has been labeled with an integration (squeezebox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of squeezebox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign squeezebox Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Sep 11 '24 16:09 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Sep 16 '24 13:09 home-assistant[bot]

Hi is there is still an issue with this one please let me know and I will revamp accordingly

pssc avatar Oct 06 '24 15:10 pssc

@pssc There is a merge conflict. Could you take a look?

Additionally, any reason you've put this PR back to draft?

../Frenck

frenck avatar Mar 02 '25 22:03 frenck

@pssc There is a merge conflict. Could you take a look?

Additionally, any reason you've put this PR back to draft?

../Frenck

Thanks @frenck I was aware stuff had changed and there where @peteS-UK merges pending and they needed landing first, and that this could be refactored to make the integration code simpler at that point as we had more smarts in the supporting lib, all done now.

pssc avatar Mar 04 '25 13:03 pssc