core icon indicating copy to clipboard operation
core copied to clipboard

Update Amberelectric to use amberelectric version 2.0.0

Open madpilot opened this issue 1 year ago • 1 comments

Breaking change

Proposed change

Type of change

  • [x] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • Bump amberelectric.py dependency to version 2. Link to amberelectric.py release changelog: https://github.com/madpilot/amberelectric.py/releases/tag/v2.0.0

Checklist

  • [X] The code change is tested and works locally.
  • [X] Local tests pass. Your PR cannot be merged unless tests pass
  • [X] There is no commented out code in this PR.
  • [X] I have followed the development checklist
  • [X] I have followed the perfect PR recommendations
  • [X] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [X] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

madpilot avatar Sep 10 '24 21:09 madpilot

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Sep 11 '24 08:09 home-assistant[bot]

The 2.0.1 release doesn't exist yet on GitHub.

MartinHjelmare avatar Oct 29 '24 11:10 MartinHjelmare

Tagged the release https://github.com/madpilot/amberelectric.py/releases/tag/v2.0.1

madpilot avatar Oct 29 '24 11:10 madpilot

Also putting to draft because of pending comments

joostlek avatar Oct 29 '24 19:10 joostlek

Please make sure to update the link to the source release in the PR description when changing the version that is targeted in the PR, and update the PR title etc.

MartinHjelmare avatar Oct 31 '24 09:10 MartinHjelmare

Amazing. Thank you!

madpilot avatar Nov 20 '24 22:11 madpilot