Fix serial handling in ViCare integration

[CFenner]

Proposed change

Type of change

• [ ] Dependency upgrade
• [x] Bugfix (non-breaking change which fixes an issue)
• [ ] New integration (thank you!)
• [ ] New feature (which adds functionality to an existing integration)
• [ ] Deprecation (breaking change to happen in the future)
• [ ] Breaking change (fix/feature causing existing functionality to break)
• [ ] Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes
• This PR is related to issue: https://github.com/home-assistant/core/issues/125443 https://github.com/home-assistant/core/issues/125464
• Link to documentation pull request:

Checklist

• [ ] The code change is tested and works locally.
• [x] Local tests pass. Your PR cannot be merged unless tests pass
• [x] There is no commented out code in this PR.
• [x] I have followed the development checklist
• [x] I have followed the perfect PR recommendations
• [x] The code has been formatted using Ruff (ruff format homeassistant tests)
• [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• [ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• [ ] The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• [ ] New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• [ ] I have reviewed two other open pull requests in this repository.

[CFenner]

There seems to be an issue with the migration when there are multiple devices connected via the same gateway: https://github.com/home-assistant/core/issues/125443#issuecomment-2338902944

[cagnulein]

PR works on 2024.9.2 Please merge!

[gonzo8855]

HA 2024.9.2 was released yesterday. These fixes seeem not to be in. How can I get the information that this fix is implemented in HA main branch?

[Mobyone42]

HA 2024.9.2 was released yesterday. These fixes seeem not to be in. How can I get the information that this fix is implemented in HA main branch?

This issue is inside the ViCare plugin, not HA. Once the consolidation of the review has been approved, then we will have a new version of the plugin to install.

[nyn3x]

HA 2024.9.2 was released yesterday. These fixes seeem not to be in. How can I get the information that this fix is implemented in HA main branch?

This issue is inside the ViCare plugin, not HA. Once the consolidation of the review has been approved, then we will have a new version of the plugin to install.

But aren't these plugins bundled within HA? Or are they downloaded separately? I thought only plugins through HACS would be updated separately.

[rolandsteinmeyer]

But aren't these plugins bundled within HA? Or are they downloaded separately? I thought only plugins through HACS would be updated separately.

vicare is part HA but review of the PR is still pending. This has to be done by other developers for QA reasons which is a good thing. Considering the timeframe remember these are mostly volunteers. Once review is done the PR will be merged into the next HA patch Release. If it is more urgent for you you can apply the patch directly if you have some dev experience with this script. You will get a copy of the stock vicare integration in custom_components/vicare with the patch applied. Of course afterwards you need to restart HA. Before upgrading HA you need to remove this folder.

[MartinHjelmare]

Please don't comment on PRs unless it's related to the code in the PR. Thanks!

[frenck]

Removed this PR from the patch milestone. I could not cleanly merge it onto our current stable release. It will be part of 2024.10.0 next week instead.