core icon indicating copy to clipboard operation
core copied to clipboard

Fix Fujitsu fglair authentication error and other issues

Open crevetor opened this issue 1 year ago • 2 comments

Breaking change

Proposed change

This fixes a few issues that have been reported. Changes in the device package :

  • Return false instead of raising an exception when reading an unsupported property
  • Raise an error if the device is offline
  • Add app secrets for china and europe
  • Fix refresh

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #124947 fixes #125274 and fixes #124971
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

crevetor avatar Sep 06 '24 20:09 crevetor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Sep 08 '24 10:09 home-assistant[bot]

If you continue with c068675, let me know, or you can open a PR to remove the relevant code.

Your PRs were merged and released as v1.4.0 tonight.

rewardone avatar Sep 10 '24 01:09 rewardone

Removed this PR from the patch milestone, as I could not cleanly merge it into the current stable branches.

frenck avatar Sep 23 '24 17:09 frenck