core icon indicating copy to clipboard operation
core copied to clipboard

Allow github requirements specs in hassfest for non-core components

Open mpw96 opened this issue 1 year ago • 6 comments

Breaking change

No.

Proposed change

We don't need to try to mimik what pip will later do anyways, because later hassfest will install the dependencies - errors in the requirements specifications will show there.

Type of change

  • [ ] Dependency upgrade
  • [X] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: https://github.com/home-assistant/actions/issues/92.
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [X] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

mpw96 avatar Aug 30 '24 13:08 mpw96

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Aug 30 '24 13:08 home-assistant[bot]

Git requirements are not allowed in core.

MartinHjelmare avatar Aug 30 '24 14:08 MartinHjelmare

Git requirements are not allowed in core.

Okay, I modified the check to be more lenient only in custom integrations. I also added tests for this.

mpw96 avatar Sep 01 '24 20:09 mpw96

alinging with uv as @edenhaus has suggested.

mpw96 avatar Sep 04 '24 12:09 mpw96

@MartinHjelmare Sorry to bother you. Is there anything going to happen here? If you don't want hassfest to allow this please close the pull request. Thank you very much!

mpw96 avatar Sep 14 '24 18:09 mpw96

This is on the agenda for the next core meeting. I'll update here when we have a conclusion.

MartinHjelmare avatar Sep 16 '24 08:09 MartinHjelmare