Improve intent recognition in default conversation agent

[arturpragacz]

Proposed change

Improve intent recognition in default conversation agent:

• use the same logic for custom sentences
• prefer higher quality (longer) names

Type of change

• [ ] Dependency upgrade
• [x] Bugfix (non-breaking change which fixes an issue)
• [ ] New integration (thank you!)
• [ ] New feature (which adds functionality to an existing integration)
• [ ] Deprecation (breaking change to happen in the future)
• [ ] Breaking change (fix/feature causing existing functionality to break)
• [ ] Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• [x] The code change is tested and works locally.
• [x] Local tests pass. Your PR cannot be merged unless tests pass
• [x] There is no commented out code in this PR.
• [x] I have followed the development checklist
• [x] I have followed the perfect PR recommendations
• [x] The code has been formatted using Ruff (ruff format homeassistant tests)
• [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• [ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• [ ] The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• [ ] New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• [ ] I have reviewed two other open pull requests in this repository.

[home-assistant[bot]]

Hey there @home-assistant/core, @synesthesiam, mind taking a look at this pull request as it has been labeled with an integration (conversation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of conversation can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign conversation Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[synesthesiam]

Thanks!

[epenet]

It looks like this causes CI failures

=========================== short test summary info ============================
FAILED tests/components/conversation/test_init.py::test_turn_on_intent[None-turn on kitchen-None] - homeassistant.helpers.intent.UnknownIntent: Unknown intent CustomIntent

[arturpragacz]

@epenet I cannot replicate this on my local machine. It also wouldn't make sense for these functional changes to have this effect.

What I think is actually going on is that in testing we set up a temporary custom_sentences file. And this file is accidentally being picked up by other unrelated tests running in parallel. Since in this PR more custom sentences were added to that file, it makes those other tests fail randomly.

Let me know whether I'm on the right track here - whether what I am saying makes sense in the context of HA testing infrastructure.

[epenet]

@epenet I cannot replicate this on my local machine. It also wouldn't make sense for these functional changes to have this effect.

What I think is actually going on is that in testing we set up a temporary custom_sentences file. And this file is accidentally being picked up by other unrelated tests running in parallel. Since in this PR more custom sentences were added to that file, it makes those other tests fail randomly.

Let me know whether I'm on the right track here - whether what I am saying makes sense in the context of HA testing infrastructure.

Yes it's highly possible that temporary files affect other tests It sounds like you're on the right track

[arturpragacz]

@epenet Thanks for the confirmation.

#128490 should fix it.