core icon indicating copy to clipboard operation
core copied to clipboard

Allow fetching Reddit user posts

Open NicolasNewman opened this issue 1 year ago • 5 comments

Proposed change

  • Adds an additional configuration option to the Reddit integration to allow fetching Redditor comments/posts

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [X] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • [X] The code change is tested and works locally.
  • [X] Local tests pass. Your PR cannot be merged unless tests pass
  • [X] There is no commented out code in this PR.
  • [X] I have followed the development checklist
  • [X] I have followed the perfect PR recommendations
  • [X] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [X] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

NicolasNewman avatar Aug 18 '24 01:08 NicolasNewman

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Aug 18 '24 01:08 home-assistant[bot]

@joostlek I'll work on a separate PR that adds a config flow and hopefully have it opened by the end of this week.

NicolasNewman avatar Sep 09 '24 13:09 NicolasNewman

Let me know if you need any help :)

joostlek avatar Sep 09 '24 14:09 joostlek

A bit caught up with other obligations at the moment. The config flow is complete but I need to finish the unit tests.

NicolasNewman avatar Sep 16 '24 12:09 NicolasNewman

Awesome!

joostlek avatar Sep 16 '24 12:09 joostlek

I switched the dependency the integration uses from praw to asyncpraw for asynchronous capabilities. There's a dependency resolution issue that prevents asyncpraw from being added to the requirements. I've opened an issue (https://github.com/praw-dev/asyncpraw/issues/284) on their repo where they've mentioned prioritizing a release with the fix. I'll put this on hold for a week to see if it can be released by then.

NicolasNewman avatar Sep 20 '24 14:09 NicolasNewman

Async sounds awesome. Can we migrate the current integration to be async before we add the flow? Otherwise the PR scope gets too big

joostlek avatar Sep 20 '24 15:09 joostlek

Because there hasn't been any activity on this PR for quite some time now, I've decided to close it for being stale.

Feel free to re-open this PR when you are ready to pick up work on it again 👍

frenck avatar Nov 08 '24 20:11 frenck