core icon indicating copy to clipboard operation
core copied to clipboard

Add Reolink chime play action

Open starkillerOG opened this issue 1 year ago • 4 comments

Breaking change

Proposed change

Add Reolink chime play action. This replaces the chime_play select entity that was rejected in PR: https://github.com/home-assistant/core/pull/122752/commits/dba43b026ca968c753ccce63f8d80c28447d11bf

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/34149

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

starkillerOG avatar Aug 06 '24 13:08 starkillerOG

~A version bump of reolink-aio is now required due to the new host.api.chime(chime_id) function now beeing needed.~

starkillerOG avatar Aug 06 '24 21:08 starkillerOG

~Here is the version bump of reolink-aio: https://github.com/home-assistant/core/pull/123263~

starkillerOG avatar Aug 06 '24 21:08 starkillerOG

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Aug 13 '24 21:08 home-assistant[bot]

Sorry for taking so long to adress the review comments

starkillerOG avatar Aug 22 '24 08:08 starkillerOG

When I think about this again, why didn't we make a siren entity for this feature?

MartinHjelmare avatar Aug 26 '24 19:08 MartinHjelmare