core icon indicating copy to clipboard operation
core copied to clipboard

Add inverter-devices to solarlog

Open dontinelli opened this issue 6 months ago • 6 comments

Proposed change

Add additional sensors for inverter-devices (and possibly other devices) that are connected with the Solar-Log. For the moment two additional sensors are added (power and consumption).

The user may choose in an OptionFlow, for which devices he would like to fetch the additional data.

I'm aware that all in all the PR became quite big. As the pieces are interlinked, I found it difficult, though, to split it up in different PR (in particular the OptionFlow does not make sense without the new devices and vice versa).

Dependency upgrade has been moved to separate PR (https://github.com/home-assistant/core/pull/123218) but is still a prerequisite for this PR.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/34136

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

~~- [ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.~~ ~~- [ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.~~ ~~- [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.~~

To help with the load of incoming pull requests:

dontinelli avatar Aug 05 '24 18:08 dontinelli