core
core copied to clipboard
Fix RecursionError in Husqvarna Automower coordinator
Breaking change
Proposed change
Instead of recursing in the same task the coordinator creates a new background task for the call to client_listen on retry
Type of change
- [ ] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #123008
- This PR is related to issue:
- Link to documentation pull request:
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [x] I have followed the perfect PR recommendations
- [x] The code has been formatted using Ruff (
ruff format homeassistant tests) - [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [ ] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
@Thomas55555 You need to click the "Ready for review"-button if you're done with addressing review comments and you want the PR to be reviewed again.
Thanks, I know. But I haven't addressed all comments. And I'm not sure I can. But I also don't want to close the PR, because the issue is fixed and only the tests are not right.
Thanks, I know. But I haven't addressed all comments. And I'm not sure I can. But I also don't want to close the PR, because the issue is fixed and only the tests are not right.
Oh, I see. If you need some help, feel free to contact me on Discord, my nick there is @emontnemery
Did you intend to push some commits?
Did you intend to push some commits?
Yes, commit 564f4d1 👍