core icon indicating copy to clipboard operation
core copied to clipboard

Add generate content service for OpenAI to match Google AI

Open timlaing opened this issue 1 year ago • 2 comments

Proposed change

Extended the OpenAI Conversation integration such that it contains an equivalent generate_content service as the Google AI integration. This allows for feature parity between these two integrations. This is important for countries that the Free tier of Google AI is not provided.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [X] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/34072

Checklist

  • [X] The code change is tested and works locally.
  • [X] Local tests pass. Your PR cannot be merged unless tests pass
  • [X] There is no commented out code in this PR.
  • [X] I have followed the development checklist
  • [X] I have followed the perfect PR recommendations
  • [X] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [X] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

timlaing avatar Jul 29 '24 23:07 timlaing

Hey there @balloob, mind taking a look at this pull request as it has been labeled with an integration (openai_conversation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of openai_conversation can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign openai_conversation Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Jul 29 '24 23:07 home-assistant[bot]

I have updated the code to fix the issues from the code checks. Also rebased against latest dev.

timlaing avatar Oct 06 '24 19:10 timlaing

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Nov 08 '24 14:11 home-assistant[bot]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

github-actions[bot] avatar Jan 08 '25 16:01 github-actions[bot]

I believe I have addressed all of your comments.

timlaing avatar Jan 31 '25 14:01 timlaing

Left some comments that need addressing.

Thanks for the feedback - these comments have been addressed.

timlaing avatar Mar 03 '25 21:03 timlaing

Some more changes requested.

Thanks again for your comments. I believe that these have been addressed correctly.

timlaing avatar Mar 07 '25 07:03 timlaing

Sorry for the long delay and thank you for patience. Approved! 🐬 ✅

balloob avatar Mar 15 '25 01:03 balloob

Sorry for the long delay and thank you for patience. Approved! 🐬 ✅

Not a problem thank you too.

timlaing avatar Mar 15 '25 08:03 timlaing