Add sound modes to Bang & Olufsen devices
Proposed change
Add sound mode selection to the media_player entity.
The Bang & Olufsen App allows users to create sound modes with identical names, which is problematic because Home Assistant only uses a string is used to determine selection, which makes it impossible to determine the selection of two identically named sound modes.
Therefore the unique ID of the sound mode has been appended to the sound mode's name in Home Assistant.
For example: the test sound mode is now called test (100).
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [x] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [x] I have followed the perfect PR recommendations
- [x] The code has been formatted using Ruff (
ruff format homeassistant tests) - [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [x] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [ ] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
For example: the
testsound mode is now calledtest - 100.
Would it not be prettier with brackets?
test (100)
For example: the
testsound mode is now calledtest - 100.Would it not be prettier with brackets?
test (100)
Yeah that looks better. Changed now.
Marking as draft as tests are failing
Is there anything left for me to do here?
I've marked this PR, as there are merge conflicts; Can you please take a look? Please un-draft it once it is ready for review again by clicking the "Ready for review" button.
Thanks! 👍
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1: