core icon indicating copy to clipboard operation
core copied to clipboard

Improve flume test coverage

Open allenporter opened this issue 1 year ago • 1 comments

Proposed change

Add tests for the Flume integration init which reproduces the issue in #120618 and can help make sure the next upgrade is working. The tests use the requests mocker exercising the flume library instead of mocking out the entire thing.

$ py.test tests/components/flume --cov-report=term-missing --cov=homeassistant.
components.flume 
Name                                            Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------
homeassistant/components/flume/__init__.py         55      0   100%
homeassistant/components/flume/config_flow.py      69      0   100%
homeassistant/components/flume/const.py            30      0   100%
-----------------------------------------------------------------------------
TOTAL                                             154      0   100%

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [x] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue:
  • This PR is related to issue: #120618
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

allenporter avatar Jun 30 '24 05:06 allenporter

Hey there @chrismandich, @bdraco, @jeeftor, mind taking a look at this pull request as it has been labeled with an integration (flume) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of flume can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign flume Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Jun 30 '24 05:06 home-assistant[bot]

I've marked this PR, as changes are requested that need to be processed. Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

../Frenck

Learn more about our pull request process.

frenck avatar Jun 30 '24 12:06 frenck