core icon indicating copy to clipboard operation
core copied to clipboard

Add port mapping entry count sensor to upnp

Open StevenLooman opened this issue 1 year ago • 3 comments

Proposed change

Add a new sensor which reads the number of port mappings (port forwards) the router currently has. This sensor is generally only available through eventing, though some devices support the (unofficial) action PortMappingNumberOfEntries.

This PR depends on https://github.com/home-assistant/core/pull/120262

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

StevenLooman avatar Jun 23 '24 19:06 StevenLooman

Apologies for the unclarity, balloob. This depends on #120262. The original PR was complete/included all the required things, but a bit large for a single PR.

StevenLooman avatar Jun 24 '24 19:06 StevenLooman

That makes a lot more sense :)

balloob avatar Jun 25 '24 03:06 balloob

This is ready now. Feel free to do another review!

StevenLooman avatar Jun 30 '24 06:06 StevenLooman