core icon indicating copy to clipboard operation
core copied to clipboard

Add new integration for AiDot

Open s1eedz opened this issue 1 year ago • 16 comments

Proposed change

Add new integration for aidot

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/32704
  • This uses the third-party python-aidot Python module available at https://github.com/AiDot-Development-Team/python-AiDot

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [x] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

s1eedz avatar May 13 '24 02:05 s1eedz

This is the 4th time you have opened this PR. What is going on?

image

balloob avatar May 13 '24 03:05 balloob

I made some mistakes earlier, such as not adding a GitHub link to pypi, not writing the correct code owner, etc., so I closed the previous PR, which is currently the only PR that is open.

s1eedz avatar May 13 '24 05:05 s1eedz

This is the 4th time you have opened this PR. What is going on?

image

I'm very sorry, I'm not very familiar with the operation of GitHub. I mistakenly thought that PR needed to be closed in order to restart it. I carefully studied the operating procedures of GitHub before realizing that it could be re pushed and reopened. I apologize for any confusion caused.

s1eedz avatar May 14 '24 01:05 s1eedz

My family bought AiDot products, and I am looking forward to being able to control the lights on homeAssit, which is much more convenient for me

ManBali avatar May 16 '24 08:05 ManBali

@balloob Do I need to modify anything in this current PR? I see that there has been no new news for a long time. What is wrong with this PR? What can I modify so that it can be merged smoothly?

s1eedz avatar May 21 '24 02:05 s1eedz

Do I need to modify anything in this current PR? I see that there has been no new news for a long time.

It has not been a long time. This PR is just a week old. If you look at the list of PRs, there is a much longer list of PRs awaiting review.

Please have some patience. Thanks 👍

For more information about our pull request, see here: https://developers.home-assistant.io/docs/review-process

../Frenck

frenck avatar May 21 '24 07:05 frenck

Do I need to modify anything in this current PR? I see that there has been no new news for a long time.

It has not been a long time. This PR is just a week old. If you look at the list of PRs, there is a much longer list of PRs awaiting review.

Please have some patience. Thanks 👍

For more information about our pull request, see here: https://developers.home-assistant.io/docs/review-process

../Frenck

OK If there is any problem that needs to be modified by me, please tell us in time and we will correct it as soon as possible. Thanks.

s1eedz avatar May 21 '24 09:05 s1eedz

There seems to be issues reported by our CI. Please make sure all tests (and the full pre-commit) passes.

../Frenck

frenck avatar Jul 07 '24 20:07 frenck

Please un-draft it once the CI passes and it is ready for review again by clicking the "Ready for review" button.

Learn more about our pull request process.

frenck avatar Jul 07 '24 20:07 frenck

There seems to be issues reported by our CI. Please make sure all tests (and the full pre-commit) passes.

../Frenck

Thanks@Frenck,I have solved the ci problem according to the prompt.

s1eedz avatar Jul 17 '24 01:07 s1eedz

@frenck ,hello,I'm in my forked project, CI is running fine, can I click the "Ready for review" button now?

s1eedz avatar Aug 13 '24 04:08 s1eedz

@frenck ,hello,I'm in my forked project, CI is running fine, can I click the "Ready for review" button now?

You don't need to ask for permission to mark he PR ready for review, just do it if you think CI is passing and you want the PR to be reviewed 👍

emontnemery avatar Aug 21 '24 11:08 emontnemery

@frenck ,hello,I'm in my forked project, CI is running fine, can I click the "Ready for review" button now?

You don't need to ask for permission to mark he PR ready for review, just do it if you think CI is passing and you want the PR to be reviewed 👍

ok,Thanks

s1eedz avatar Aug 26 '24 01:08 s1eedz

@s1eedz if you want the PR to be reviewed, please click the ready for review button.

emontnemery avatar Sep 05 '24 06:09 emontnemery

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Oct 15 '24 13:10 home-assistant[bot]

The failing tests in the mariadb CI job are unrelated to the AiDot integration. Please review and fix the pylint errors though.

emontnemery avatar Oct 15 '24 13:10 emontnemery

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

github-actions[bot] avatar Dec 14 '24 16:12 github-actions[bot]