core icon indicating copy to clipboard operation
core copied to clipboard

Update Ecovacs supported lifespans

Open Ulfmerbold2000 opened this issue 9 months ago • 4 comments

Breaking change

Proposed change

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Ulfmerbold2000 avatar May 09 '24 08:05 Ulfmerbold2000

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar May 09 '24 08:05 home-assistant[bot]

Hey there @overloadut, @mib1185, @edenhaus, @augar, mind taking a look at this pull request as it has been labeled with an integration (ecovacs) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ecovacs can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ecovacs Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar May 09 '24 08:05 home-assistant[bot]

Sorry for my dumb question, but where i find the translation files for that integration? I've done the Translation for the files de.json and en.json, but this directory from my HA-Installation is missing here in github.

As you surely seen "github" is'nt my native playground so please be patient with me I've uploaded that files now here(the wrong place i'm sure, sorry for that): de.json en.json

Ulfmerbold2000 avatar May 09 '24 09:05 Ulfmerbold2000

Translations are done with lokalize and the translations files are not checked in on github. More information about contributing to translation can be found https://developers.home-assistant.io/docs/translations

edenhaus avatar May 09 '24 17:05 edenhaus

After you have done the requested changes, please click "Ready for review", so we know the PR is ready for another review

edenhaus avatar May 23 '24 08:05 edenhaus