core
core copied to clipboard
Implement Android TV Remote source list and activity list
Breaking change
Proposed change
In the configure/options page allow users to provide a mapping: app id <-> app name. Code in config_flow.py
and strings.json
was copied from the Android Debug Bridge integration.
Change the media player and remote entities to use that mapping for converting app id to the more readable app name. Also add support for source list and activity list accordingly to make it easier to launch apps.
Ignore the dependency upgrade. That is being done in https://github.com/home-assistant/core/pull/116906
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [x] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/32661
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [x] I have followed the perfect PR recommendations
- [x] The code has been formatted using Ruff (
ruff format homeassistant tests
) - [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [x] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest
. - [ ] New or updated dependencies have been added to
requirements_all.txt
.
Updated by runningpython3 -m script.gen_requirements_all
. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc
.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Hey there @drafteed, mind taking a look at this pull request as it has been labeled with an integration (androidtv_remote
) you are listed as a code owner for? Thanks!
Code owner commands
Code owners of androidtv_remote
can trigger bot actions by commenting:
-
@home-assistant close
Closes the pull request. -
@home-assistant rename Awesome new title
Renames the pull request. -
@home-assistant reopen
Reopen the pull request. -
@home-assistant unassign androidtv_remote
Removes the current integration label and assignees on the pull request, add the integration domain after the command. -
@home-assistant add-label needs-more-information
Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. -
@home-assistant remove-label needs-more-information
Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
Personally I'm of the opinion that the list of applications should be stored in the media browser under the Applications
section. This is more convenient because it allows you to switch the view of lists and tiles, plus it can also contain application icons.
Here is an example from the Bravia TV integration:
The list of sources, in my opinion, should contain a list of device inputs:
However, as far as I know, there are no clear standards for this case in HA and some integrations make a list of applications in the list of sources. So it's probably ok.
Anyway it's a good change 👍 I'll try to check it tomorrow.
I went with how Android Debug Bridge was doing it. I agree that this should be in the apps and not sources for the media player entity. I didn't know that was supported. Do you think you could make the changes? In a future PR if you could also add optional icon in the options flow it would be great.
I added support for app icons and changed the media player to support browse media.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1: