core icon indicating copy to clipboard operation
core copied to clipboard

Ecovacs Integration missing TWO Lifetime counters

Open Ulfmerbold2000 opened this issue 9 months ago • 2 comments

The problem

Following two counters are missing: <LifeSpan.UNIT_CARE: 'unitCare'>, <LifeSpan.ROUND_MOP: 'roundMop'>

I've done the needed changes for myself, now the missing Sensors show up in my HA and reset of that entities works to. The languagefiles for DE and EN extended...

ecovacs_lifetimesensor_upgrade.zip

Added my modded files, usage at own risk! For the Devs of that integration, feel free to use for an little integration upgrade :)

What version of Home Assistant Core has the issue?

core-2024.5.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

ECOVACS

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

Ulfmerbold2000 avatar May 08 '24 15:05 Ulfmerbold2000

@Ulfmerbold2000 as this is an open source project that relies on its community, you are very welcome to submit a PR to update the code and add the missing sensors.

mib1185 avatar May 08 '24 19:05 mib1185

Hey there @overloadut, @edenhaus, @augar, mind taking a look at this issue as it has been labeled with an integration (ecovacs) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ecovacs can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign ecovacs Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


ecovacs documentation ecovacs source (message by IssueLinks)

home-assistant[bot] avatar May 09 '24 08:05 home-assistant[bot]

Hi @Ulfmerbold2000 do you mind to file a PR to contribute your additions to the code?

mib1185 avatar May 22 '24 15:05 mib1185

Before i can do the work there is a bit work in deebot-client to do(last updates from Ecovacs have brought four more lifetime entities) If they all in the base deebot-client, i'll try my best to expand the integration in this point.

Ulfmerbold2000 avatar May 23 '24 06:05 Ulfmerbold2000