core icon indicating copy to clipboard operation
core copied to clipboard

Ensure config entry setup lock is held when removing a config entry

Open bdraco opened this issue 1 month ago • 3 comments

Proposed change

It was possible that the config entry was in a setup retry state and trying to setup when the user would try to remove the entry

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

bdraco avatar May 08 '24 14:05 bdraco

looks like there is unmocked I/O in the test and we were trying to remove it when its being setup there so it now times out.

Need to fix the test first

bdraco avatar May 08 '24 21:05 bdraco

need to audit for any other integration that is trying to delete the config entry that is being setup

bdraco avatar May 09 '24 15:05 bdraco

every other integration used a task or did not remove itself

bdraco avatar May 09 '24 15:05 bdraco