core icon indicating copy to clipboard operation
core copied to clipboard

Lyric: Only pull priority rooms when its an LCC device

Open dalinicus opened this issue 9 months ago • 1 comments

Breaking change

Proposed change

Fix an issue where TCC thermostats would fail to load when checking for device accessories via the priority api endpoint. Restrict checking for device accessories to LCC devices only.

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #116665
  • This PR is related to issue:
  • Link to documentation pull request: n/a

Checklist

  • [ ] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

dalinicus avatar May 05 '24 17:05 dalinicus

Hey there @timmo001, mind taking a look at this pull request as it has been labeled with an integration (lyric) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lyric can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign lyric Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar May 05 '24 17:05 home-assistant[bot]

I have ran the changes locally and can confirm the additional check added to the code above fixes issue #116665.

nprez83 avatar May 08 '24 09:05 nprez83

Hi @timmo001, wondering if we can get this PR approved so it can be added to one of the upcoming updates. Thx in advance.

nprez83 avatar May 21 '24 08:05 nprez83

I'm having the same issue on my system. Lyric thermostat is unavailable after version 2021.4.2. I have to keep rolling back to this version. Any possibility of having this PR merged into the code? https://github.com/timmo001

hughbussell avatar Jun 10 '24 23:06 hughbussell