core icon indicating copy to clipboard operation
core copied to clipboard

Reolink integration - no way to change or reset password - integration becomes unusable

Open HVR88 opened this issue 9 months ago • 1 comments

The problem

If the password on any Reolink device, such as camera or NVR is changed through Reolink's own settings, the integration in Home assistant will not be able to connect.

As there is no way to re-enter or reconfigure login or password details for the integration, all affected devices become unusable and must be deleted.

Severity: Critical

What version of Home Assistant Core has the issue?

core-2024.5.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Reolink

Link to integration documentation on our website

https://www.home-assistant.io/integrations/reolink

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

A way to edit both LOGIN name and PASSWORD for every instance of the integration is necessary to remedy the issue.

image

HVR88 avatar May 05 '24 17:05 HVR88

Hey there @starkillerog, mind taking a look at this issue as it has been labeled with an integration (reolink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of reolink can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign reolink Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


reolink documentation reolink source (message by IssueLinks)

home-assistant[bot] avatar May 05 '24 17:05 home-assistant[bot]

This one bit me too, hard!

wittend avatar Jun 22 '24 19:06 wittend

Pretty sure I'm going to end up removing this integration. It doesn't work well, doesn't get the updates it needs and there's no attention to bugs like this which can leave the setup unusable.

Maybe 2025 will be the year of video and camera support in core can be greatly improved.

HVR88 avatar Jun 22 '24 19:06 HVR88

I'll keep that in mind. Thanks.

On Sat, 22 Jun 2024 at 14:39, Bruno @.***> wrote:

Pretty sure I'm going to end up removing this integration. It doesn't work well, doesn't get the updates it needs and there's no attention to bugs like this which can leave the setup unusable.

Maybe 2025 will be the year of video and camera support in core can be greatly improved.

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/116875#issuecomment-2184166300, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACSMIUFFQZSTGWDKNNQ5J3ZIXHGTAVCNFSM6AAAAABHH37FUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBUGE3DMMZQGA . You are receiving this because you commented.Message ID: @.***>

wittend avatar Jun 22 '24 21:06 wittend

@HVR88 I have improved the upstream reolink-aio library to recognize wrong passwords better in release 0.8.10. This improvement was included from HA 2024.5.4 onward. That should improve the situation, the Reolink integration should now recognize a changed password and initiate a Re-Authentication flow prompting the user to supply the new username/password. I tried this out on my E1 zoom and it worked on that model.

However, even if the Reolink integration does not recognize the wrong password correctly, you are always able to change the username/password/IP-adress like this: Go to settings->Devices & Services -> Reolink IP NVR/camera -> click the "add item" and then set it up the reolink integration with the new IP as if it is a brand new camera. (withouth removing the old instance) The config flow will recognize that the camera is already been setup before and will abort the flow with such a message. But it will then update the IP and username/password to the new provided information and the existing instance should start working again.

This method is not specific to Reolink but general for most integrations.

starkillerOG avatar Jun 23 '24 15:06 starkillerOG

@HVR88 regarding not getting updates, that is just planely wrong. Since your post on May 5th the upstream reolink-aio library has had 7 new releases with 66 commits/changes involving 803 changed lines of code: https://github.com/starkillerOG/reolink_aio/compare/0.8.8...0.9.3

On top of that I made 22 PRs in the HomeAssistant part of the reolink code since May 5th (when you posted this issue): https://github.com/home-assistant/core/commits/dev/homeassistant/components/reolink

So do your research when claiming the integration "doesn't get the updates it needs".

It is true that I am behind on the bug reports like these over the past 2 months since I have been working very hard on getting Reolink Battery cameras supported (which they now are), that required a lot of work and I put my attention on that for a while. Now I am shifting back to the bug reports and hoping to catch up on those fast.

That beeing said, what asspect besides the change/reset of the password of the reolink integration is not working for you?

starkillerOG avatar Jun 23 '24 15:06 starkillerOG

This is all open source volunteers so I appreciate the efforts you’ve gone through! Thanks!

robpneu avatar Jun 23 '24 15:06 robpneu

Thank you for your excellent work!

On Sun, 23 Jun 2024 at 10:13, starkillerOG @.***> wrote:

Closed #116875 https://github.com/home-assistant/core/issues/116875 as completed.

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/116875#event-13255955963, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACSMISVTUAS24MQKL7DZ4DZI3QZLAVCNFSM6AAAAABHH37FUWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGI2TKOJVGU4TMMY . You are receiving this because you commented.Message ID: @.***>

wittend avatar Jun 23 '24 15:06 wittend