core
core copied to clipboard
command_line: Do not lead to erroring out code indexing None or empty discovery_info
Proposed change
Just make code more "correct" as signature allows for None
but then code assumes that it is a DiscoveryInfoType
.
In this case also in case of an empty constract or none - just return with a warning (since I guess it is unexpected)
Type of change
-
[ ] Dependency upgrade
-
[x] Bugfix (non-breaking change which fixes an issue)
-
[ ] New integration (thank you!)
-
[ ] New feature (which adds functionality to an existing integration)
-
[ ] Deprecation (breaking change to happen in the future)
-
[ ] Breaking change (fix/feature causing existing functionality to break)
-
[ ] Code quality improvements to existing code or addition of tests
-
This PR fixes or closes issue: fixes #116871
Checklist
- [ ] The code change is tested and works locally.
- [ ] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [ ] I have followed the development checklist
- [ ] I have followed the perfect PR recommendations
- [ ] The code has been formatted using Ruff (
ruff format homeassistant tests
) - [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest
. - [ ] New or updated dependencies have been added to
requirements_all.txt
.
Updated by runningpython3 -m script.gen_requirements_all
. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc
.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
Hey there @gjohansson-st, mind taking a look at this pull request as it has been labeled with an integration (command_line
) you are listed as a code owner for? Thanks!
Code owner commands
Code owners of command_line
can trigger bot actions by commenting:
-
@home-assistant close
Closes the pull request. -
@home-assistant rename Awesome new title
Renames the pull request. -
@home-assistant reopen
Reopen the pull request. -
@home-assistant unassign command_line
Removes the current integration label and assignees on the pull request, add the integration domain after the command. -
@home-assistant add-label needs-more-information
Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. -
@home-assistant remove-label needs-more-information
Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.