core icon indicating copy to clipboard operation
core copied to clipboard

Finished fetching lyric_coordinator data in 0.380 seconds (success: False) After 2024.5.0 update

Open satnitfver opened this issue 9 months ago • 8 comments

The problem

Not making connection, after reboot an removed

What version of Home Assistant Core has the issue?

2024.5.0

What was the last working version of Home Assistant Core?

2024.4.0

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

Honeywell lyric

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

satnitfver avatar May 03 '24 02:05 satnitfver

please provide more details, Luke anything helpful from your logs, what was configured, error messages, what has already been done to trying to solve the issue, thx 👍

mib1185 avatar May 03 '24 20:05 mib1185

Hey there @timmo001, mind taking a look at this issue as it has been labeled with an integration (lyric) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lyric can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign lyric Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


lyric documentation lyric source (message by IssueLinks)

home-assistant[bot] avatar May 03 '24 20:05 home-assistant[bot]

I'm having the same problem after updating to 2024.5.

I own a lyric round and a T5. I've narrowed the problem to the lyric round. If I don't select it when adding the integration the T5 actually adds and work fine. This was not the case before 2024.5.

I've looked at the logs and can't see anything useful yet. But I'll update here as I discover more.

nprez83 avatar May 04 '24 12:05 nprez83

Here are the log entries related to the integration:

2024-05-04 08:59:15.643 DEBUG (MainThread) [aiolyric.objects.base] [{'locationID': XXXXXXXX, 'name': 'XXXXXXXX', 'streetAddress': XXXXXXXX, 'devices': [{'thermostatVersion': '02.03.20.00', 'scheduleStatus': 'Pause', 'allowedTimeIncrements': 15, 'settings': {'homeSetPoints': {'homeHeatSP': 70, 'homeCoolSP': 78, 'units': 'Fahrenheit'}, 'awaySetPoints': {'awayHeatSP': 62, 'awayCoolSP': 85, 'smartCoolSP': 80, 'smartHeatSP': 55, 'useAutoSmart': False, 'units': 'Fahrenheit'}, 'hardwareSettings': {'brightness': 6, 'volume': 10, 'maxBrightness': 10, 'maxVolume': 10}, 'fan': {'allowedModes': ['Auto', 'On', 'Circulate'], 'changeableValues': {'mode': 'Auto'}, 'fanRunning': False}, 'temperatureMode': {'feelsLike': True, 'air': True}, 'specialMode': {'autoChangeoverActive': True}}, 'deviceClass': 'Thermostat', 'deviceType': 'Thermostat', 'deviceID': 'TCC-3490528', 'deviceInternalID': 4644338, 'userDefinedDeviceName': 'My Lyric', 'name': 'My Lyric', 'schedule': {'scheduleType': 'None'}, 'isAlive': True, 'isUpgrading': False, 'isProvisioned': False, 'macID': 'XXXXXXXX', 'deviceSettings': {}, 'service': {'mode': 'Up'}, 'deviceRegistrationDate': '2022-11-06T23:57:34.4433333', 'units': 'Fahrenheit', 'indoorTemperature': 74, 'outdoorTemperature': 66, 'allowedModes': ['Cool', 'Heat', 'Off'], 'deadband': 0, 'hasDualSetpointStatus': False, 'minHeatSetpoint': 40, 'maxHeatSetpoint': 99, 'minCoolSetpoint': 40, 'maxCoolSetpoint': 99, 'changeableValues': {'mode': 'Auto', 'autoChangeoverActive': True, 'heatSetpoint': 70, 'coolSetpoint': 74, 'heatCoolMode': 'Cool'}, 'operationStatus': {'mode': 'EquipmentOff'}, 'smartAway': {'active': False, 'timeOfDay': '00:00:00', 'durationInHours': 2, 'durationInDays': 0, 'lastUsedFormat': 'TimeOfDay', 'endsIn': '2000-01-01T00:00:00-05:00'}, 'indoorHumidity': 58, 'indoorHumidityStatus': 'Measured', 'deviceModel': 'Round'}], 'users': [XXXXXXXX], 'isOptOut': '', 'isCurrentUser': False}], 'timeZoneId': 'Eastern', 'timeZone': 'Eastern Standard Time', 'ianaTimeZone': 'America/New_York', 'daylightSavingTimeEnabled': True, 'geoFenceEnabled': False, 'predictiveAIREnabled': False, 'comfortLevel': 0, 'geoFenceNotificationEnabled': True, 'geoFenceNotificationTypeId': 13, 'configuration': {'faceRecognition': {'enabled': False, 'maxPersons': 2, 'maxEtas': 2, 'maxEtaPersons': 1, 'schedules': [{'time': [{'start': '15:00:00', 'end': '17:00:00'}], 'days': ['Sunday', 'Monday', 'Tuesday', 'Wednesday', 'Thursday', 'Friday', 'Saturday']}]}}, 'stateName': 'XXXXXXXX'}, {'locationID': XXXXXXXX, 'name': 'XXXXXXXX', 'streetAddress': XXXXXXXX, 'devices': [{'displayedOutdoorHumidity': 77, 'vacationHold': {'enabled': False}, 'currentSchedulePeriod': {'day': 'Monday', 'period': 'Away'}, 'scheduleCapabilities': {'availableScheduleTypes': ['None', 'Geofenced', 'TimedNorthAmerica'], 'schedulableFan': False}, 'scheduleType': {'scheduleType': 'Timed', 'scheduleSubType': 'NA'}, 'changeSource': {'by': 'partner', 'name': 'Home Assistant'}, 'scheduleStatus': 'Pause', 'allowedTimeIncrements': 15, 'settings': {'hardwareSettings': {'brightness': 1, 'maxBrightness': 5}, 'fan': {'allowedModes': ['On', 'Auto', 'Circulate'], 'changeableValues': {'mode': 'Auto'}}, 'temperatureMode': {'air': True}, 'specialMode': {'autoChangeoverActive': True}, 'devicePairingEnabled': True}, 'deviceOsVersion': 'RCHT8610WF2006', 'deviceClass': 'Thermostat', 'deviceType': 'Thermostat', 'deviceID': 'LCC-48A2E6C6614C', 'deviceInternalID': 5351902, 'userDefinedDeviceName': 'XXXXXXXX', 'name': 'XXXXXXXX', 'isAlive': False, 'isUpgrading': False, 'isProvisioned': True, 'macID': 'XXXXXXXX', 'deviceSettings': {}, 'service': {'mode': 'Up'}, 'deviceRegistrationDate': '2023-07-09T16:32:25.3333333', 'dataSyncStatus': 'Completed', 'deviceSerialNo': '2312LBJ09906', 'units': 'Fahrenheit', 'indoorTemperature': 72, 'outdoorTemperature': 81.5, 'allowedModes': ['Heat', 'Off', 'Cool', 'Auto'], 'deadband': 0, 'hasDualSetpointStatus': False, 'minHeatSetpoint': 50, 'maxHeatSetpoint': 90, 'minCoolSetpoint': 50, 'maxCoolSetpoint': 90, 'changeableValues': {'mode': 'Auto', 'autoChangeoverActive': True, 'heatSetpoint': 68, 'coolSetpoint': 72, 'thermostatSetpointStatus': 'PermanentHold', 'heatCoolMode': 'Cool'}, 'operationStatus': {'mode': 'Cool', 'fanRequest': True, 'circulationFanRequest': False}, 'deviceModel': 'T5-T6'}], 'users': [XXXXXXXX], 'timeZoneId': 'Eastern', 'timeZone': 'Eastern Standard Time', 'ianaTimeZone': 'America/New_York', 'daylightSavingTimeEnabled': True, 'geoFenceEnabled': False, 'predictiveAIREnabled': False, 'comfortLevel': 0, 'geoFenceNotificationEnabled': False, 'geoFenceNotificationTypeId': 13, 'configuration': {'faceRecognition': {'enabled': False, 'maxPersons': 2, 'maxEtas': 2, 'maxEtaPersons': 1, 'schedules': [{'time': [{'start': '15:00:00', 'end': '17:00:00'}], 'days': ['Sunday', 'Monday', 'Tuesday', 'Wednesday', 'Thursday', 'Friday', 'Saturday']}]}}, 'stateName': 'XXXXXXXX'}]
2024-05-04 08:59:15.723 DEBUG (MainThread) [homeassistant.components.lyric] Finished fetching lyric_coordinator data in 0.723 seconds (success: False)

nprez83 avatar May 04 '24 13:05 nprez83

As I mentioned, if I only select my T5 and not the Lyric Round when adding the integration, fetching lyric_coordinator data is successful, so the problem is related to the Lyric Round.

The only change related to the Lyric integration implemented in 2024.5 was #104343 by @dalinicus, which added support for room based sensors linked to lyric thermostats. I have no room sensors associate with either the Round or the T5, and I don't think the Round supports room sensors. I grabbed the latest version of the lyric component source code from 2024.4.4 and ran that, and everything works well, which further suggests the problem may be related to PR #104343.

@emontnemery, @timmo001, and @dalinicus, any chance you could review the code associated with #104343 and see if there's anything that may be affecting the Lyric Round (which is a TCC devide) but not the T5 (which is an LCC device)? I'll check as well but figured I'd tag you since you're likely already familiar with the changes made in #104343.

nprez83 avatar May 04 '24 13:05 nprez83

Based on your description, I would guess the issue is occurring when priority api endpoint is called to get device sensors. There is a check for device type before the call is made, but I'd put money on the endpoint returning a non-successful status for thermostats without priority support. Might need to make a check for specifically the T5 and T6 series thermostats instead, or possibly see if there's an indicator for priority support in the device info.

image

Do you have any logs you can attach?

Or what would be really helpful is if you know how to call the Homeywell Home API, if you can provide the json returned by the devices endpoint, and see if the priority endpoint throws an error for the lyric round.

dalinicus avatar May 05 '24 15:05 dalinicus

Based on your description, I would guess the issue is occurring when priority api endpoint is called to get device sensors. There is a check for device type before the call is made, but I'd put money on the endpoint returning a non-successful status for thermostats without priority support. Might need to make a check for specifically the T5 and T6 series thermostats instead, or possibly see if there's an indicator for priority support in the device info.

image

Do you have any logs you can attach?

Or what would be really helpful is if you know how to call the Homeywell Home API, if you can provide the json returned by the devices endpoint, and see if the priority endpoint throws an error for the lyric round.

You're probably on the right track. My logs are a couple posts above. If you look at the climate.py code, there are several parts where we do different things for TCC (Round) vs LCC (T5/6) devices, I wonder if we can implement a similar check for this case. I can use the Honeywell API today and confirm what it returns, but I do think the easiest fix is to implement your changes for LCC devices only, as I suspect the TCC devices probably don't support the priority API.

nprez83 avatar May 05 '24 16:05 nprez83

@nprez83 you mind running this branch for this PR locally and seeing if it resolves your issue. https://github.com/home-assistant/core/pull/116876. If so, I'll mark it as ready.

dalinicus avatar May 05 '24 17:05 dalinicus

@nprez83 you mind running this branch for this PR locally and seeing if it resolves your issue. https://github.com/home-assistant/core/pull/116876. If so, I'll mark it as ready.

Sorry, been busy at work. Will run it ASAP and report back. Thx for the prompt response.

nprez83 avatar May 07 '24 11:05 nprez83

@dalinicus, ran the updated code and the additional check seems to have done the trick. My Lyric Round loads without issues now. Thanks again.

nprez83 avatar May 07 '24 22:05 nprez83

awesome. I've marked the PR ready for review.

dalinicus avatar May 08 '24 00:05 dalinicus

Perfect. Thanks again!

nprez83 avatar May 08 '24 08:05 nprez83

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.