core
core copied to clipboard
Refactor group setup
Breaking change
Changes the way entity platform domains register the group on/off states or exclusions. This will break any custom integrations that implement the group platform.
Proposed change
Refactor group setup up to:
- not use current_domain context var
- pass the
on
states as a tuple to allow the first state to be the default.
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [x] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [x] I have followed the perfect PR recommendations
- [x] The code has been formatted using Ruff (
ruff format homeassistant tests
) - [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest
. - [ ] New or updated dependencies have been added to
requirements_all.txt
.
Updated by runningpython3 -m script.gen_requirements_all
. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc
.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Note from a previous PR by @emontnemery related to mixed group support:
There's a single custom integration published in HACS -
bodymiscale
- which also implements mixed group support so a breaking change + blog post + notifying the author ofbodymiscale
should be fine. @dckiller51 You seem to be codeowner of the custombodymiscale
HACS integration
I don't think we have any custom components that register group states as I would expect that its only for base components.
Someone might do it though, but I'm not sure we should support that
I don't think we have any custom components that register group states as I would expect that its only for base components.
Someone might do it though, but I'm not sure we should support that
Erik knew of one custom integration, see https://github.com/home-assistant/core/pull/116317#issuecomment-2081210202 I mentioned the code owner, so hopefully that ping will reach him,
Added a developer blog post PR
Note from a previous PR by @emontnemery related to mixed group support:
There's a single custom integration published in HACS -
bodymiscale
- which also implements mixed group support so a breaking change + blog post + notifying the author ofbodymiscale
should be fine. @dckiller51 You seem to be codeowner of the custombodymiscale
HACS integration
Hello, I don't think this affects "Bodymiscale". Basically I started with the basics of the “Plant” component. In the event of a problem, we will make the necessary modifications for proper operation.