core icon indicating copy to clipboard operation
core copied to clipboard

Speed up singleton decorator so it can be used more places

Open bdraco opened this issue 2 months ago • 1 comments

Proposed change

Speed up singleton decorator so it can be used more places

This is roughly a 60% speed up to the singleton decorator. (normal functions only)

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [x] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

bdraco avatar Apr 27 '24 11:04 bdraco

performance tested with

import timeit

from homeassistant.helpers import singleton

@singleton.singleton("X")
def x(hass):
    return {}


class H:

    def __init__(self):
        self.data = {}

print(timeit.timeit(stmt='x(hass)', setup="hass=H()", number=1000000, globals={"H":H,"x":x}))

bdraco avatar Apr 27 '24 11:04 bdraco

thanks

bdraco avatar Apr 28 '24 16:04 bdraco