core icon indicating copy to clipboard operation
core copied to clipboard

Update pyLoad integration to async library PyLoadAPI 1.1.0

Open tr4nt0r opened this issue 10 months ago • 0 comments

Proposed change

Replaces the API Library, which is currently embedded into sensor.py, with an external async library.

This is part of a somewhat bigger refactoring of the integration (see https://github.com/home-assistant/core/pull/115260), but I'm splitting it up into smaller chunks. This PR introduces a new library and otherwise only parts of the code got improved, that i had to touch anyway and left the rest as is. Next PR will then introduce configuration via UI (config flow).

External API:

https://github.com/tr4nt0r/PyLoadAPI/releases/tag/1.1.0

Had to resubmit a new PR as I messed up a rebase in the previous PR (#115652) and too many people got subscribed to the PR

Type of change

  • [x] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

tr4nt0r avatar Apr 23 '24 18:04 tr4nt0r