core
core copied to clipboard
Make Idasen Desk react to bluetooth changes
Proposed change
In situations where async_ble_device_from_address returns None, the integration would never reconnect again.
This triggers the connection after the device shows up again.
This is a reopening of https://github.com/home-assistant/core/pull/105176, since the issue was still present and the assumptions in that PR that led me to close it were wrong.
Changes on idasen-ha were also made to make the connection handling more reliable to concurrency, since now we can have connect() called multiple times. This bumps idasen-ha to v2.5.3: https://github.com/abmantis/idasen-ha/compare/2.5.1...2.5.3
Type of change
- [ ] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [x] I have followed the perfect PR recommendations
- [x] The code has been formatted using Ruff (
ruff format homeassistant tests) - [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [ ] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Done. Let me know if there is a better way than the await asyncio.sleep(0.1) thingy.