core icon indicating copy to clipboard operation
core copied to clipboard

Add config flow to Media Extractor

Open joostlek opened this issue 10 months ago • 1 comments

Breaking change

Configuring media extractor via YAML is deprecated, it has been imported if you had it in your YAML.

Proposed change

Add config flow to Media Extractor

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/32590

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

joostlek avatar Apr 16 '24 20:04 joostlek

Also this:

Detected blocking call to import_module inside the event loop by integration 'media_extractor' at
homeassistant/components/media_extractor/__init__.py, line 95: youtube_dl = YoutubeDL( (offender: 
/workspaces/ha-core/.venv/lib/python3.12/site-packages/yt_dlp/plugins.py, line 125: pkg = 
importlib.import_module(fullname)),

tr4nt0r avatar Apr 17 '24 21:04 tr4nt0r