core icon indicating copy to clipboard operation
core copied to clipboard

Add GoDice integration

Open anton-ptashnik opened this issue 1 year ago • 5 comments

Breaking change

NO

Proposed change

Add GoDice integration to enable the device act as a home control.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/31884

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

anton-ptashnik avatar Mar 11 '24 13:03 anton-ptashnik

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Mar 11 '24 13:03 home-assistant[bot]

@LennP please point me to the place where I need to add integration README

anton-ptashnik avatar Mar 14 '24 11:03 anton-ptashnik

@LennP please point me to the place where I need to add integration README

Documentation needs to be included in the home-assistant.io repository under /source/_integrations, also make sure to use the right next branch as will be mentioned in the pull request template

The core_integrations folder in the brands repository should include icons and logos for your integration

LennP avatar Mar 14 '24 11:03 LennP

@LennP it looks like I addressed all your comments for now. Please re-check and approve if possible, thanks!

anton-ptashnik avatar Mar 21 '24 17:03 anton-ptashnik

I'm marking this as draft since there are unresolved review comments. Once you've addressed them, please hit the "Ready for review"-button @anton-ptashnik 👍

emontnemery avatar May 16 '24 06:05 emontnemery

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

github-actions[bot] avatar Sep 05 '24 19:09 github-actions[bot]