core icon indicating copy to clipboard operation
core copied to clipboard

Add more icon translations to Bring

Open tr4nt0r opened this issue 1 year ago • 5 comments

Proposed change

Change icon to shopping cart with a checkmark (mdi:cart-check) when shopping is done and list is empty or all completed ( state==0)

Add more icons for lists with special purpouse

Screenshot 2024-02-25 211624

image

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

tr4nt0r avatar Feb 25 '24 20:02 tr4nt0r

Hey there @miaucl, mind taking a look at this pull request as it has been labeled with an integration (bring) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of bring can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign bring Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Feb 25 '24 20:02 home-assistant[bot]

@joostlek follow-up to what we were discussing in #111351 Maybe it's too much icons or still not enough but i think it looks neat ^^

tr4nt0r avatar Feb 25 '24 20:02 tr4nt0r

You're always overwriting the translation key now

joostlek avatar Feb 25 '24 20:02 joostlek

Oh, that's not how it supposed to be done?

tr4nt0r avatar Feb 25 '24 20:02 tr4nt0r

You're always overwriting the translation key now

I don't know if i understand what you mean, the icon translation keys are only overwritten or set when the list is initialized. Only if i change the theme in Bring and reload the integration the icon translation key is updated and a different icon is shown. When i change the entity icon in HA in the entity settings, it stays like that (as expected), even if i change the theme in Bring, it is not overwritten. If i change the entity icon back to default, it takes again the icon that is set by the integration via the icon translation key.

tr4nt0r avatar Feb 25 '24 22:02 tr4nt0r

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Mar 15 '24 11:03 home-assistant[bot]