core icon indicating copy to clipboard operation
core copied to clipboard

Add binary sensor platform to microBees

Open FedDam opened this issue 1 year ago • 3 comments

Breaking change

Proposed change

add binary sensor platform

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [X] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/31577

Checklist

  • [X] The code change is tested and works locally.
  • [X] Local tests pass. Your PR cannot be merged unless tests pass
  • [X] There is no commented out code in this PR.
  • [X] I have followed the development checklist
  • [X] I have followed the perfect PR recommendations
  • [X] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [X] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [X] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [X] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

FedDam avatar Feb 23 '24 09:02 FedDam

Hey there @microbeestech, mind taking a look at this pull request as it has been labeled with an integration (microBees) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of microBees can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign microBees Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Feb 23 '24 09:02 home-assistant[bot]

I've also created a PR to change the for loops to list comprehension for you: PR link

Yeah, I hate list comprehension too. I usually write it as a for loop and then have ChatGPT convert it into an equivalent list comprehension.

rlippmann avatar Feb 23 '24 16:02 rlippmann

@bdraco any comments on the entity naming scheme here?

rlippmann avatar Feb 23 '24 17:02 rlippmann

@bdraco waiting your review to merge

marcolettieri avatar Mar 08 '24 14:03 marcolettieri