core icon indicating copy to clipboard operation
core copied to clipboard

Remove hourly weather entity from Aemet

Open gjohansson-ST opened this issue 1 year ago • 1 comments

Breaking change

The Aemet integration previously created two entities for each configured location, one entity which provided daily weather forecasts and one entity which provided hourly forecasts. The Aemet integration now only creates a single entity which provides both daily and hourly weather forecasts.

Proposed change

Remove the hourly weather entity from Aemet and instead provide hourly + daily forecasts in one entity

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [x] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

gjohansson-ST avatar Feb 16 '24 23:02 gjohansson-ST

Hey there @noltari, mind taking a look at this pull request as it has been labeled with an integration (aemet) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of aemet can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign aemet Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Feb 16 '24 23:02 home-assistant[bot]

@gjohansson-ST this PR has conflicts after my latest AEMET changes. I've fixed those conflicts for you in the following branches:

  • Rebase: https://github.com/Noltari/home-assistant-core/commits/aemet-remove-hourly-entity_rebase/
  • Merge: https://github.com/Noltari/home-assistant-core/commits/aemet-remove-hourly-entity_merge/

Noltari avatar Feb 27 '24 18:02 Noltari