core icon indicating copy to clipboard operation
core copied to clipboard

Avoid creating tasks to load integration platforms that do not exist

Open bdraco opened this issue 4 months ago • 2 comments

~~needs https://github.com/home-assistant/core/pull/110751~~ needs #110766

Proposed change

Instead of checking if the integration platform exists in the task we now check before creating the task. This avoids hundreds (almost 1000) tasks at startup. This is where most startup tasks come from. It even beat out ConfigEntries.async_forward_entry_setup

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [x] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

bdraco avatar Feb 16 '24 18:02 bdraco

Its still failing unfortunately.

bdraco avatar Feb 17 '24 00:02 bdraco

reverted the original version and came up with a smaller, better fix in https://github.com/home-assistant/core/pull/110766

bdraco avatar Feb 17 '24 02:02 bdraco

No changes here since the last review besides merging in dev.

bdraco avatar Feb 17 '24 13:02 bdraco

Thanks!

bdraco avatar Feb 17 '24 13:02 bdraco