core icon indicating copy to clipboard operation
core copied to clipboard

Add camera recording service to blink

Open mback2k opened this issue 1 year ago • 3 comments

Revival of #46598 by @fronzbot with the review feedback from @MartinHjelmare incorporated.

Proposed change

Adds a service to allow Blink cameras to be triggered to record a video.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/31435

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [x] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

mback2k avatar Feb 14 '24 20:02 mback2k

Hey there @fronzbot, @mkmer, mind taking a look at this pull request as it has been labeled with an integration (blink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of blink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign blink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Feb 14 '24 20:02 home-assistant[bot]

Automated Checks failed with unrelated GitHub Error: API rate limit exceeded for installation ID 689304.

mback2k avatar Feb 14 '24 21:02 mback2k

You can try updating with dev branch or close the reopen to trigger a re-run of the tests/checks.

Rebased to current dev branch, done.

Everything else looks "good".

Thanks.

mback2k avatar Feb 15 '24 19:02 mback2k

@fronzbot @mkmer anything else I can do to get this merged?

mback2k avatar Mar 10 '24 16:03 mback2k

Just wait for a maintainer to review & merge. Patience is the game :)

mkmer avatar Mar 10 '24 16:03 mkmer

@MartinHjelmare hey, would you mind taking a look at this? sorry for bothering you and thanks in advance!

mback2k avatar Apr 15 '24 06:04 mback2k

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Apr 21 '24 03:04 home-assistant[bot]