core icon indicating copy to clipboard operation
core copied to clipboard

Add ECO temp to Generic Thermostat

Open Minims opened this issue 1 year ago • 4 comments

Proposed change

Add the preset ECO temperature in Generic Thermostat

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/31415

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Minims avatar Feb 13 '24 12:02 Minims

I can't find the repo to update the documentation, Thx.

Minims avatar Feb 13 '24 12:02 Minims

I can't find the repo to update the documentation, Thx.

https://github.com/home-assistant/home-assistant.io

PeteRager avatar Feb 13 '24 17:02 PeteRager

We need to have a test added for this new preset to verify operation. I would put it here:

https://github.com/home-assistant/core/blob/2981d7ed0ec78f2271f5b6fac26a98d1b1b280df/tests/components/generic_thermostat/test_climate.py#L309

PeteRager avatar Feb 13 '24 18:02 PeteRager

I have add :

  • tests with Eco mode in Climate.
  • PR in the documentation https://github.com/home-assistant/home-assistant.io/pull/31415

Minims avatar Feb 13 '24 20:02 Minims