core icon indicating copy to clipboard operation
core copied to clipboard

Improve ability to debug one time listeners blocking the event loop

Open bdraco opened this issue 4 months ago • 0 comments

Proposed change

Improve ability to debug one time listeners blocking the event loop. I couldn't tell where the slow code was before because the repr wasn't very helpful before.

before 2024-02-08 16:51:10.120 WARNING (MainThread) [asyncio] Executing <Handle _OneTimeListener.async_call(<Event homeassistant_started[L]>) created at /Users/bdraco/home-assistant/homeassistant/core.py:601> took 2.074 seconds

after 2024-02-08 16:58:28.981 WARNING (MainThread) [asyncio] Executing <Handle _OneTimeListener(hass=<HomeAssistant RUNNING>, listener=<function async_setup.<locals>._async_initialize at 0x10ff2be20>, remove=None)(<Event homeassistant_started[L]>) created at /Users/bdraco/home-assistant/homeassistant/core.py:601> took 1.992 seconds

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [x] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

bdraco avatar Feb 08 '24 23:02 bdraco