core
core copied to clipboard
Update python rflink to 0.0.66
Used to manage new data WIND from last R51 release
Breaking change
Proposed change
Type of change
- [x] Dependency upgrade
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes wind sensors in rflink R51.
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [] I have followed the development checklist
- [ ] I have followed the perfect PR recommendations
- [ ] The code has been formatted using Ruff (
ruff format homeassistant tests
) - [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest
. - [ ] New or updated dependencies have been added to
requirements_all.txt
.
Updated by runningpython3 -m script.gen_requirements_all
. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc
.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Hey there @javicalle, mind taking a look at this pull request as it has been labeled with an integration (rflink
) you are listed as a code owner for? Thanks!
Code owner commands
Code owners of rflink
can trigger bot actions by commenting:
-
@home-assistant close
Closes the pull request. -
@home-assistant rename Awesome new title
Renames the pull request. -
@home-assistant reopen
Reopen the pull request. -
@home-assistant unassign rflink
Removes the current integration label and assignees on the pull request, add the integration domain after the command. -
@home-assistant add-label needs-more-information
Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request. -
@home-assistant remove-label needs-more-information
Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.
Changelog: https://github.com/aequitas/python-rflink/compare/0.0.65...0.0.66
You need to run the script:
python3 -m script.gen_requirements_all
Or you can update the requirements_all.txt
file.
@javicalle i have updated the requirements
It seems that the requirements_test_all.txt
must be also updated (and maybe others).
EDIT: that would be enough (see PR #89601)
It seems that the
requirements_test_all.txt
must be also updated (and maybe others).EDIT: that would be enough (see PR #89601)
It might be OK now i hope.
Is there an open bug here or upstream regarding this? it would be good to link it to the PR description
Is there an open bug here or upstream regarding this? it would be good to link it to the PR description
PR on python-rflink: https://github.com/aequitas/python-rflink/pull/75 Issue on RFLINK forum: https://www.letscontrolit.com/forum/viewtopic.php?p=68108#p68108
@balloob Do you need something else for this PR to be reviewed ? Thx :-)
@Minims don't tag people into the PR unless they are already a part of the conversation. I don't see why you tagged that specific person. PR description is still missing some information, I edited it and added the information, please make sure to include the diff link / release notes on the PR description.
@thecode sorry for that, i tag him because he has reviewed the last PR about RFlink.
Many thanks !